Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Analytics(stake): add tx type tracking #4218

Merged
merged 1 commit into from
Sep 20, 2024
Merged

Conversation

compojoom
Copy link
Collaborator

What it solves

With the changes in this pr we will be able to distinguish between deposit, exit and withdraw tx initiated through the stake widget.

How this PR fixes it

This PR introduces logic to differentiate between various staking transaction types, such as deposit, exit, and withdraw, by adding the isAnyStakingTxInfo utility. The getTransactionTrackingType function is updated to recognize these transaction types, ensuring that the correct transaction type is logged when a staking-related transaction is processed.

How to test it

Submit deposit, exit and withdraw txs. In the browser terminal you should see the GTM tag sent.

Screenshots

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

Copy link

github-actions bot commented Sep 20, 2024

Copy link

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 954.25 KB (🟡 +13 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Seven Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/apps/open 54.74 KB (🟡 +9 B) 1008.99 KB
/transactions 73.53 KB (🟡 +9 B) 1 MB
/transactions/history 73.49 KB (🟡 +9 B) 1 MB
/transactions/messages 39.16 KB (🟡 +9 B) 993.42 KB
/transactions/msg 29.52 KB (🟡 +9 B) 983.77 KB
/transactions/queue 31.27 KB (🟡 +9 B) 985.52 KB
/transactions/tx 21.07 KB (🟡 +9 B) 975.32 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

Copy link

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
78.26% (+0.02% 🔼)
12021/15361
🔴 Branches
58.25% (+0.03% 🔼)
3086/5298
🟡 Functions
65.32% (+0.05% 🔼)
1893/2898
🟡 Lines
79.78% (+0.02% 🔼)
10852/13603
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / tx-tracking.ts
87.88% (-2.44% 🔻)
81.25% (-5.42% 🔻)
100%
87.5% (-2.5% 🔻)

Test suite run success

1485 tests passing in 203 suites.

Report generated by 🧪jest coverage report action from 10f92f7

@katspaugh katspaugh changed the title chore(stake): add analytics Analytics(stake): add tx type tracking Sep 20, 2024
Copy link
Member

@katspaugh katspaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

Analytics tracking

@compojoom compojoom merged commit 43c0f9e into dev Sep 20, 2024
16 checks passed
@compojoom compojoom deleted the chore-stake-analytics branch September 20, 2024 11:24
@github-actions github-actions bot locked and limited conversation to collaborators Sep 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants